Vulnerability & Bug Fixes #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on deployment testing observed that when this function is called it reverts as it attempts to delegatecall to a non existent contract to execute this function. fixed by changing it from public to internal.
due to the previous method of calculation it leads to value of < InterstLib.ONE when called early on. This results in amountOwed going to 0 over time rather than increasing as intended leading to loss for USDC lender. Fixed by calculating the linear auction rate with a baseline from InterestLib.ONE
match vuln fix update for rate calc.
previous version used offerId for requests and requestId for offers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes are
More details are in the individual commit descriptions. Looking forward to contributing back and making the repository better, learnt a lot diving into the code and deploying a functional version of it.